fix(coverage): non-awaited module imports cause wrong offsets#10643
Merged
AriPerkkio merged 1 commit intoJun 23, 2026
Merged
Conversation
AriPerkkio
force-pushed
the
fix/coverage-pending-module-imports
branch
from
June 22, 2026 14:14
09d5dae to
6797760
Compare
AriPerkkio
marked this pull request as ready for review
June 22, 2026 14:39
AriPerkkio
force-pushed
the
fix/coverage-pending-module-imports
branch
from
June 22, 2026 16:42
6797760 to
5b7e5f4
Compare
hi-ogawa
approved these changes
Jun 23, 2026
Comment on lines
+334
to
+340
| // Initialize execution info in case worker exited before module evaluation finished | ||
| this.options.moduleExecutionInfo?.set(options.filename, { | ||
| duration: 0, | ||
| selfTime: 0, | ||
| startOffset: codeDefinition.length, | ||
| importer, | ||
| }) |
Collaborator
There was a problem hiding this comment.
This also allows showing pending dynamic import in import duration list. 0 isn't intended but probably better than being not tracked at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #10581
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.