Skip to content

fix: fix setImmediate await in detect-async-leak #10608

Merged
hi-ogawa merged 1 commit into
vitest-dev:mainfrom
hi-ogawa:fix/async-leak-setimmediate-wait
Jun 16, 2026
Merged

fix: fix setImmediate await in detect-async-leak #10608
hi-ogawa merged 1 commit into
vitest-dev:mainfrom
hi-ogawa:fix/async-leak-setimmediate-wait

Conversation

@hi-ogawa

Copy link
Copy Markdown
Collaborator

Description

Just spotted await Promise.resolve(setImmediate) which appeared to be the typo.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa changed the title fix: wait for setImmediate when detecting async leaks fix: fix setImmediate await in detect-async-leak Jun 16, 2026

@AriPerkkio AriPerkkio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@hi-ogawa
hi-ogawa marked this pull request as ready for review June 16, 2026 06:19
@hi-ogawa
hi-ogawa merged commit dd62b84 into vitest-dev:main Jun 16, 2026
19 of 20 checks passed
@hi-ogawa
hi-ogawa deleted the fix/async-leak-setimmediate-wait branch June 16, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants