chore(deps): update playwright 1.60.0#10426
Merged
sheremet-va merged 5 commits intoMay 29, 2026
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Also hit another issue with <1.60.0 |
Co-authored-by: Codex <[email protected]>
Co-authored-by: Codex <[email protected]>
hi-ogawa
commented
May 28, 2026
| '9898', | ||
| '--host', | ||
| '127.0.0.1', | ||
| '--unsafe', |
Collaborator
Author
There was a problem hiding this comment.
Playwright now requires explicit --unsafe for remote launchOptions.args (args: [`--user-agent=VitestLaunchOptionsTester`] in our test).
| }) | ||
|
|
||
| await cli.waitForStdout('Listening on ws://localhost:9898') | ||
| await cli.waitForStdout('Listening on ws://127.0.0.1:9898') |
Collaborator
Author
There was a problem hiding this comment.
Playwright tweaked the output so enforcing ipv4.
hi-ogawa
marked this pull request as ready for review
May 29, 2026 03:22
sheremet-va
approved these changes
May 29, 2026
hi-ogawa
added a commit
to hi-ogawa/vitest
that referenced
this pull request
Jun 26, 2026
Playwright 1.60+ run-server binds to ::1 (IPv6) when host is localhost, so the test's 'Listening on ws://localhost:9898' wait never matches the 'ws://[::1]:9898/' output and times out. Pass --host 127.0.0.1 --unsafe and use 127.0.0.1 everywhere, matching main (vitest-dev#10426). Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason, playwright test in
test/uiis hanging on my machine. Updating playwright fixes it.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.