Skip to content

fix!: don't emit localStorage warnings on Node 26, fail gracefully when worker fails to start#10293

Merged
sheremet-va merged 8 commits into
vitest-dev:mainfrom
sheremet-va:chore/run-node-26
Jul 1, 2026
Merged

fix!: don't emit localStorage warnings on Node 26, fail gracefully when worker fails to start#10293
sheremet-va merged 8 commits into
vitest-dev:mainfrom
sheremet-va:chore/run-node-26

Conversation

@sheremet-va

@sheremet-va sheremet-va commented May 7, 2026

Copy link
Copy Markdown
Member

Description

Resolves #issue-number

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 9a3f227
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a441de5e844a20008d40637
😎 Deploy Preview https://deploy-preview-10293--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va changed the title ci: run tests in Node 26 fix!: don't emit localStorage warnings on Node 26 Jun 30, 2026
hi-ogawa
hi-ogawa reviewed Jun 30, 2026
View reviewed changes
Comment thread packages/vitest/src/node/pools/poolRunner.ts

@hi-ogawa hi-ogawa Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a separate independent fix?

@sheremet-va sheremet-va Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. This PR was initially just to add support for Node 26, I could split it into separate PRs if you want. It's small enough that I was too lazy and just kept it here :P

@hi-ogawa hi-ogawa Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like separate PR, but also fine if it's included in pr title and description properly.

@sheremet-va sheremet-va Jul 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, included in title 😄

Comment thread packages/vitest/src/integrations/env/jsdom-keys.ts
'innerHeight',
'innerWidth',
'length',
'localStorage',

@hi-ogawa hi-ogawa Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot what this means. Does this mean previously we didn't expose local/sessionStorage as jsdom/happy-dom global?

@sheremet-va sheremet-va Jul 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we didn't override new window's keys if the value exists on globalThis already. This list basically says "override anyway"

@hi-ogawa hi-ogawa Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see. getWindowKeys loop is mind-bending and took a while to comprehend 😓

@sheremet-va sheremet-va changed the title fix!: don't emit localStorage warnings on Node 26 fix!: don't emit localStorage warnings on Node 26, fail gracefully when worker fails to start Jul 1, 2026
hi-ogawa
hi-ogawa approved these changes Jul 1, 2026
View reviewed changes
Comment thread packages/vitest/src/integrations/env/jsdom-keys.ts
'innerHeight',
'innerWidth',
'length',
'localStorage',

@hi-ogawa hi-ogawa Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see. getWindowKeys loop is mind-bending and took a while to comprehend 😓

@sheremet-va
sheremet-va merged commit 334edef into vitest-dev:main Jul 1, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes
@AriPerkkio AriPerkkio Awaiting requested review from AriPerkkio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @hi-ogawa