Skip to content

docs: document browser mode auto cleanup behavior#10045

Merged
hi-ogawa merged 13 commits intovitest-dev:mainfrom
hi-ogawa:docs-document-auto-cleanup-behavior
Apr 8, 2026
Merged

docs: document browser mode auto cleanup behavior#10045
hi-ogawa merged 13 commits intovitest-dev:mainfrom
hi-ogawa:docs-document-auto-cleanup-behavior

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Apr 2, 2026 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa changed the title docs: document auto cleanup behavior docs: document browser mode auto cleanup behavior Apr 2, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 2, 2026 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fce23be
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69d5a5d4dc7e120008009f25
😎 Deploy Preview https://deploy-preview-10045--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa
hi-ogawa commented Apr 3, 2026
View reviewed changes
Comment thread test/browser/fixtures/user-event-hover/vitest.config.ts
Comment on lines +8 to +12
// TODO:
// playwright/firefox doesn't seem to have mouse state isolation per frames.
// for example, the following can fail by race conditions:
// BROWSER=firefox pnpm -C test/browser/ test-fixtures --root fixtures/user-event-hover --browser.headless --fileParallelism
fileParallelism: false,
Copy link
Copy Markdown
Collaborator Author

@hi-ogawa hi-ogawa Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is expected. Is it the issue on vitest or playwright? Should we track the issue?

Copy link
Copy Markdown
Member

@sheremet-va sheremet-va Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I would expect it to spawn different contexts with different positions, although since it's not chromium maybe it works differently

@hi-ogawa hi-ogawa marked this pull request as ready for review April 3, 2026 03:06
sheremet-va
sheremet-va approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should track and reset only if needed, but I'm not sure

@hi-ogawa hi-ogawa mentioned this pull request Apr 8, 2026
Open
@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

hi-ogawa commented Apr 8, 2026

Also another concern is that actually resetting cursor position seems a bit tricky. unhover just move cursors to the body. On playwright, I tried { position: { x: -1, y: -1 } } and webkit got broken. With { x: 0, y : 0 }, not sure if this can still hover the element at the top left.

Even if we want, I'm not sure it's possible to absolutely reset the cursor.

@hi-ogawa hi-ogawa merged commit 3a8b1d1 into vitest-dev:main Apr 8, 2026
16 checks passed
@hi-ogawa hi-ogawa deleted the docs-document-auto-cleanup-behavior branch April 8, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cursors position not reset between tests?

2 participants

@hi-ogawa @sheremet-va