fix(browser): always derive a positive locator action timeout (#10626)

sheremet-va · web-flow · commit 5b8642120d3b · 2026-06-23T23:19:41.000+02:00
diff --git a/packages/browser/src/client/tester/tester-utils.ts b/packages/browser/src/client/tester/tester-utils.ts
@@ -245,11 +245,10 @@ export function processTimeoutOptions<T extends { timeout?: number }>(options_:
   const currentTime = now()
   const endTime = startTime + timeout
   const remainingTime = Math.floor(endTime - currentTime)
-  if (remainingTime <= 0) {
-    return options_
-  }
-  // give us some time to process the timeout
-  options_.timeout = remainingTime - 100
+  // keep some buffer to process the timeout, but always hand the provider a
+  // positive value so it surfaces a descriptive, source-mapped locator error
+  // instead of letting the task timer win the race with a generic timeout
+  options_.timeout = Math.max(remainingTime - 100, 1)
   return options_
 }
 
diff --git a/test/browser/fixtures/timeout-hooks/hooks-timeout.test.ts b/test/browser/fixtures/timeout-hooks/hooks-timeout.test.ts
@@ -4,40 +4,40 @@ import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, onTes
 describe.runIf(server.provider === 'playwright')('timeouts are failing correctly', () => {
   it('click on non-existing element fails', async () => {
     await page.getByRole('code').click()
-  }, 150)
+  }, 500)
 
   it('expect.element on non-existing element fails', async () => {
     await expect.element(page.getByRole('code')).toBeVisible()
-  }, 150)
+  }, 1000)
 
   describe('beforeEach', () => {
     beforeEach(async () => {
       await page.getByTestId('non-existing').click()
-    }, 150)
+    }, 500)
 
     it('skipped', () => {})
   })
 
   describe('afterEach', () => {
     afterEach(async () => {
       await page.getByTestId('non-existing').click()
-    }, 150)
+    }, 500)
 
     it('skipped', () => {})
   })
 
   describe('beforeAll', () => {
     beforeAll(async () => {
       await page.getByTestId('non-existing').click()
-    }, 150)
+    }, 500)
 
     it('skipped', () => {})
   })
 
   describe('afterAll', () => {
     afterAll(async () => {
       await page.getByTestId('non-existing').click()
-    }, 150)
+    }, 500)
 
     it('skipped', () => {})
   })
@@ -46,29 +46,29 @@ describe.runIf(server.provider === 'playwright')('timeouts are failing correctly
     it('fails', ({ onTestFinished }) => {
       onTestFinished(async () => {
         await page.getByTestId('non-existing').click()
-      }, 150)
+      }, 500)
     })
 
     it('fails global', () => {
       onTestFinished(async () => {
         await page.getByTestId('non-existing').click()
-      }, 150)
+      }, 500)
     })
   })
 
   describe('onTestFailed', () => {
     it('fails', ({ onTestFailed }) => {
       onTestFailed(async () => {
         await page.getByTestId('non-existing').click()
-      }, 150)
+      }, 500)
 
       expect.unreachable()
     })
 
     it('fails global', () => {
       onTestFailed(async () => {
         await page.getByTestId('non-existing').click()
-      }, 150)
+      }, 500)
 
       expect.unreachable()
     })
