fix(browser): don't release keyboard automatically (#6083)

sheremet-va · web-flow · commit 58fac77b3786 · 2024-07-10T17:43:46.000+02:00
diff --git a/packages/browser/src/node/commands/keyboard.ts b/packages/browser/src/node/commands/keyboard.ts
@@ -50,7 +50,7 @@ export const keyboard: UserEventCommand<UserEvent['keyboard']> = async (
         throw new TypeError(`Provider "${context.provider.name}" does not support selecting all text`)
       }
     },
-    false,
+    true,
   )
 }
 
diff --git a/test/browser/test/userEvent.test.ts b/test/browser/test/userEvent.test.ts
@@ -557,6 +557,22 @@ describe('userEvent.keyboard', async () => {
     ])
   })
 
+  test('should not auto release', async () => {
+    const spyKeydown = vi.fn()
+    const spyKeyup = vi.fn()
+    const button = document.createElement('button')
+    document.body.appendChild(button)
+    button.addEventListener('keydown', spyKeydown)
+    button.addEventListener('keyup', spyKeyup)
+    button.focus()
+    await userEvent.keyboard('{Enter>}')
+    expect(spyKeydown).toHaveBeenCalledOnce()
+    expect(spyKeyup).not.toHaveBeenCalled()
+    await userEvent.keyboard('{/Enter}')
+    // userEvent doesn't fire any event here, but should we?
+    expect(spyKeyup).not.toHaveBeenCalled()
+  })
+
   test('standalone keyboard works correctly with active input', async () => {
     const documentKeydown: string[] = []
     const inputKeydown: string[] = []

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export const keyboard: UserEventCommand<UserEvent['keyboard']> = async (`
`50`	`50`	throw new TypeError(`Provider "${context.provider.name}" does not support selecting all text`)
`51`	`51`	`}`
`52`	`52`	`},`
`53`		`- false,`
	`53`	`+ true,`
`54`	`54`	`)`
`55`	`55`	`}`
`56`	`56`