fix(react): respect tsconfig jsxImportSource by default by hi-ogawa · Pull Request #726 · vitejs/vite-plugin-react

hi-ogawa · 2025-08-16T08:06:24Z

Description

Closes plugin-react no longer respects jsxImportSource settings from tsconfig #719
Requires
- fix: merge tsconfig jsx options even when oxc.jsx.runtime is set rolldown-vite#376
- fix(rolldown_plugin_transform): merge tsconfig jsx options even when oxc.jsx.runtime is set rolldown/rolldown#5771

hi-ogawa · 2025-08-16T08:52:13Z

packages/plugin-react/src/index.ts

-                runtime: 'automatic',
-                importSource: jsxImportSource,


I needed to remove runtime too since rolldown-vite merge oxc option with tsconfig only when runtime === undefined. Is this intended or allow also runtime === 'automatic'? @sapphi-red https://github.com/vitejs/rolldown-vite/blob/f88cb05e755457fd9ea99174a017c49964510c3f/packages/vite/src/node/plugins/oxc.ts#L65-L68

With the vite-rolldown code as is, this would mean that users having jsx === 'preserve' in tsconfig will now have broken apps I think.
Is this also the same logic for the esbuild?

Ah, I didn't know react plugin is ensuring automatic so that tsconfig's jsx preserve will be ignored. Probably rolldown-vite oxc option merging needs to be tweaked. I'll also add that test case too then.

I didn't know react plugin is ensuring automatic so that tsconfig's jsx preserve will be ignored
I'm not sure it's a goal, but with the current implementation of vite-rolldown it happen to be the case.

hi-ogawa · 2025-08-18T01:50:41Z

test-build is failing because of native plugin vitejs/rolldown-vite#376 (comment)

…`oxc.jsx.runtime` is set (#5771) This PR ports vitejs/rolldown-vite#376 to builtin transform plugin to fix vitejs/vite-plugin-react#726

…`oxc.jsx.runtime` is set (#5771) This PR ports vitejs/rolldown-vite#376 to builtin transform plugin to fix_ vitejs/vite-plugin-react#726

sapphi-red · 2025-08-18T08:06:48Z

@hi-ogawa I've released rolldown-vite v7.1.3, which includes the fixes.

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

ArnaudBarre · 2025-08-18T10:07:53Z

playground/tsconfig/tsconfig.json

+    "isolatedModules": true,
+    "noEmit": true,
+    "jsx": "react-jsx",
+    "jsxImportSource": "@emotion/react",


Maybe we can update the playground/emotion to comment the manual jsxImportSource (saying we expect to be infered from tsconfig)

Good idea. I should reuse that but I'm not sure how to get esbuild to pickup tsconfig for jsx. I'll update the example to tsx in a later PR and remove this one.

| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.7.0 | 5.0.1 | ## [v5.0.1](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#501-2025-08-19) ##### Set `optimizeDeps.rollupOptions.transform.jsx` instead of `optimizeDeps.rollupOptions.jsx` for rolldown-vite ([#735](vitejs/vite-plugin-react#735)) `optimizeDeps.rollupOptions.jsx` is going to be deprecated in favor of `optimizeDeps.rollupOptions.transform.jsx`. ##### Perf: skip `babel-plugin-react-compiler` if code has no `"use memo"` when `{ compilationMode: "annotation" }` ([#734](vitejs/vite-plugin-react#734)) ##### Respect tsconfig `jsxImportSource` ([#726](vitejs/vite-plugin-react#726)) ##### Fix `reactRefreshHost` option on rolldown-vite ([#716](vitejs/vite-plugin-react#716)) ##### Fix `RefreshRuntime` being injected twice for class components on rolldown-vite ([#708](vitejs/vite-plugin-react#708)) ##### Skip `babel-plugin-react-compiler` on non client environment ([689](vitejs/vite-plugin-react#689)) ## [v5.0.0](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#500-2025-08-07)

| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.7.0 | 5.0.2 | ## [v5.0.2](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#502-2025-08-28) ##### Skip transform hook completely in rolldown-vite in dev if possible ([#783](vitejs/vite-plugin-react#783)) ## [v5.0.1](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#501-2025-08-19) ##### Set `optimizeDeps.rollupOptions.transform.jsx` instead of `optimizeDeps.rollupOptions.jsx` for rolldown-vite ([#735](vitejs/vite-plugin-react#735)) `optimizeDeps.rollupOptions.jsx` is going to be deprecated in favor of `optimizeDeps.rollupOptions.transform.jsx`. ##### Perf: skip `babel-plugin-react-compiler` if code has no `"use memo"` when `{ compilationMode: "annotation" }` ([#734](vitejs/vite-plugin-react#734)) ##### Respect tsconfig `jsxImportSource` ([#726](vitejs/vite-plugin-react#726)) ##### Fix `reactRefreshHost` option on rolldown-vite ([#716](vitejs/vite-plugin-react#716)) ##### Fix `RefreshRuntime` being injected twice for class components on rolldown-vite ([#708](vitejs/vite-plugin-react#708)) ##### Skip `babel-plugin-react-compiler` on non client environment ([689](vitejs/vite-plugin-react#689)) ## [v5.0.0](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#500-2025-08-07)

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#readme) ([source](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react)) | devDependencies | major | [`^4.5.2` → `^5.0.0`](https://renovatebot.com/diffs/npm/@vitejs%2fplugin-react/4.7.0/5.1.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/vitejs/vite-plugin-react/badge)](https://securityscorecards.dev/viewer/?uri=github.com/vitejs/vite-plugin-react) | --- ### Release Notes <details> <summary>vitejs/vite-plugin-react (@vitejs/plugin-react)</summary> ### [`v5.1.2`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#512-2025-12-08) [Compare Source](vitejs/vite-plugin-react@23db727...f127a24) ### [`v5.1.1`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#511-2025-11-12) [Compare Source](vitejs/vite-plugin-react@3e5a374...23db727) ##### Update code to support newer `rolldown-vite` ([#976](vitejs/vite-plugin-react#976)) `rolldown-vite` will remove `optimizeDeps.rollupOptions` in favor of `optimizeDeps.rolldownOptions` soon. This plugin now uses `optimizeDeps.rolldownOptions` to support newer `rolldown-vite`. Please update `rolldown-vite` to the latest version if you are using an older version. ### [`v5.1.0`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#510-2025-10-24) [Compare Source](vitejs/vite-plugin-react@450d7df...3e5a374) ##### Add `@vitejs/plugin-react/preamble` virtual module for SSR HMR ([#890](vitejs/vite-plugin-react#890)) SSR applications can now initialize HMR runtime by importing `@vitejs/plugin-react/preamble` at the top of their client entry instead of manually calling `transformIndexHtml`. This simplifies SSR setup for applications that don't use the `transformIndexHtml` API. ##### Fix raw Rolldown support for Rolldown 1.0.0-beta.44+ ([#930](vitejs/vite-plugin-react#930)) Rolldown 1.0.0-beta.44+ removed the top-level `jsx` option in favor of `transform.jsx`. This plugin now uses the `transform.jsx` option to support Rolldown 1.0.0-beta.44+. ### [`v5.0.4`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#504-2025-09-27) [Compare Source](vitejs/vite-plugin-react@8293cb3...450d7df) ##### Perf: use native refresh wrapper plugin in rolldown-vite ([#881](vitejs/vite-plugin-react#881)) ### [`v5.0.3`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#503-2025-09-17) [Compare Source](vitejs/vite-plugin-react@1f4b4d9...8293cb3) ##### HMR did not work for components imported with queries with rolldown-vite ([#872](vitejs/vite-plugin-react#872)) ##### Perf: simplify refresh wrapper generation ([#835](vitejs/vite-plugin-react#835)) ### [`v5.0.2`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#502-2025-08-28) [Compare Source](vitejs/vite-plugin-react@efe4344...1f4b4d9) ##### Skip transform hook completely in rolldown-vite in dev if possible ([#783](vitejs/vite-plugin-react#783)) ### [`v5.0.1`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#501-2025-08-19) [Compare Source](vitejs/vite-plugin-react@9e4a944...efe4344) ##### Set `optimizeDeps.rollupOptions.transform.jsx` instead of `optimizeDeps.rollupOptions.jsx` for rolldown-vite ([#735](vitejs/vite-plugin-react#735)) `optimizeDeps.rollupOptions.jsx` is going to be deprecated in favor of `optimizeDeps.rollupOptions.transform.jsx`. ##### Perf: skip `babel-plugin-react-compiler` if code has no `"use memo"` when `{ compilationMode: "annotation" }` ([#734](vitejs/vite-plugin-react#734)) ##### Respect tsconfig `jsxImportSource` ([#726](vitejs/vite-plugin-react#726)) ##### Fix `reactRefreshHost` option on rolldown-vite ([#716](vitejs/vite-plugin-react#716)) ##### Fix `RefreshRuntime` being injected twice for class components on rolldown-vite ([#708](vitejs/vite-plugin-react#708)) ##### Skip `babel-plugin-react-compiler` on non client environment ([689](vitejs/vite-plugin-react#689)) ### [`v5.0.0`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#500-2025-08-07) [Compare Source](vitejs/vite-plugin-react@8041706...9e4a944) </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!212 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>

chore(deps): update @vitejs/plugin-react (major) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#readme) ([source](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react)) | devDependencies | major | [`^4.5.2` → `^5.0.0`](https://renovatebot.com/diffs/npm/@vitejs%2fplugin-react/4.7.0/5.1.2) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/vitejs/vite-plugin-react/badge)](https://securityscorecards.dev/viewer/?uri=github.com/vitejs/vite-plugin-react) | --- ### Release Notes <details> <summary>vitejs/vite-plugin-react (@vitejs/plugin-react)</summary> ### [`v5.1.2`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#512-2025-12-08) [Compare Source](vitejs/vite-plugin-react@23db727...f127a24) ### [`v5.1.1`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#511-2025-11-12) [Compare Source](vitejs/vite-plugin-react@3e5a374...23db727) ##### Update code to support newer `rolldown-vite` ([#976](vitejs/vite-plugin-react#976)) `rolldown-vite` will remove `optimizeDeps.rollupOptions` in favor of `optimizeDeps.rolldownOptions` soon. This plugin now uses `optimizeDeps.rolldownOptions` to support newer `rolldown-vite`. Please update `rolldown-vite` to the latest version if you are using an older version. ### [`v5.1.0`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#510-2025-10-24) [Compare Source](vitejs/vite-plugin-react@450d7df...3e5a374) ##### Add `@vitejs/plugin-react/preamble` virtual module for SSR HMR ([#890](vitejs/vite-plugin-react#890)) SSR applications can now initialize HMR runtime by importing `@vitejs/plugin-react/preamble` at the top of their client entry instead of manually calling `transformIndexHtml`. This simplifies SSR setup for applications that don't use the `transformIndexHtml` API. ##### Fix raw Rolldown support for Rolldown 1.0.0-beta.44+ ([#930](vitejs/vite-plugin-react#930)) Rolldown 1.0.0-beta.44+ removed the top-level `jsx` option in favor of `transform.jsx`. This plugin now uses the `transform.jsx` option to support Rolldown 1.0.0-beta.44+. ### [`v5.0.4`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#504-2025-09-27) [Compare Source](vitejs/vite-plugin-react@8293cb3...450d7df) ##### Perf: use native refresh wrapper plugin in rolldown-vite ([#881](vitejs/vite-plugin-react#881)) ### [`v5.0.3`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#503-2025-09-17) [Compare Source](vitejs/vite-plugin-react@1f4b4d9...8293cb3) ##### HMR did not work for components imported with queries with rolldown-vite ([#872](vitejs/vite-plugin-react#872)) ##### Perf: simplify refresh wrapper generation ([#835](vitejs/vite-plugin-react#835)) ### [`v5.0.2`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#502-2025-08-28) [Compare Source](vitejs/vite-plugin-react@efe4344...1f4b4d9) ##### Skip transform hook completely in rolldown-vite in dev if possible ([#783](vitejs/vite-plugin-react#783)) ### [`v5.0.1`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#501-2025-08-19) [Compare Source](vitejs/vite-plugin-react@9e4a944...efe4344) ##### Set `optimizeDeps.rollupOptions.transform.jsx` instead of `optimizeDeps.rollupOptions.jsx` for rolldown-vite ([#735](vitejs/vite-plugin-react#735)) `optimizeDeps.rollupOptions.jsx` is going to be deprecated in favor of `optimizeDeps.rollupOptions.transform.jsx`. ##### Perf: skip `babel-plugin-react-compiler` if code has no `"use memo"` when `{ compilationMode: "annotation" }` ([#734](vitejs/vite-plugin-react#734)) ##### Respect tsconfig `jsxImportSource` ([#726](vitejs/vite-plugin-react#726)) ##### Fix `reactRefreshHost` option on rolldown-vite ([#716](vitejs/vite-plugin-react#716)) ##### Fix `RefreshRuntime` being injected twice for class components on rolldown-vite ([#708](vitejs/vite-plugin-react#708)) ##### Skip `babel-plugin-react-compiler` on non client environment ([689](vitejs/vite-plugin-react#689)) ### [`v5.0.0`](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#500-2025-08-07) [Compare Source](vitejs/vite-plugin-react@8041706...9e4a944) </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!212 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>

hi-ogawa added 2 commits August 16, 2025 17:03

fix(react): respect tsconfig jsxImportSource by default

a6aac50

fix: fix oxc

904f10a

hi-ogawa commented Aug 16, 2025

View reviewed changes

hi-ogawa marked this pull request as ready for review August 16, 2025 08:52

hi-ogawa mentioned this pull request Aug 18, 2025

fix: merge tsconfig jsx options even when oxc.jsx.runtime is set vitejs/rolldown-vite#376

Merged

hi-ogawa added 5 commits August 18, 2025 10:33

fix: fix jsx preserve and wait for vitejs/rolldown-vite#376

79eefce

test: test tsconfig jsx preserve

7e2d7b0

chore: rename

24f6386

chore: pkg.pr.new

d6ad519

chore: rename

d6feee0

hi-ogawa mentioned this pull request Aug 18, 2025

fix(rolldown_plugin_transform): merge tsconfig jsx options even when oxc.jsx.runtime is set rolldown/rolldown#5771

Merged

hi-ogawa and others added 3 commits August 18, 2025 17:43

Merge branch 'main' into fix-tsconfig-jsxImportSource

e53f1f1

docs: update CHANGELOG for tsconfig jsxImportSource fix

16e4ecd

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

chore: cleanup

ea00b55

hi-ogawa force-pushed the fix-tsconfig-jsxImportSource branch from 3948fc1 to ea00b55 Compare August 18, 2025 09:06

ArnaudBarre reviewed Aug 18, 2025

View reviewed changes

docs: readme

6c65e50

hi-ogawa merged commit e2f0c78 into main Aug 19, 2025
20 checks passed

hi-ogawa deleted the fix-tsconfig-jsxImportSource branch August 19, 2025 02:17

hi-ogawa mentioned this pull request Aug 19, 2025

test(react): update playground/react-emotion to tsx and remove playground/tsconfig #737

Merged

chrisbbreuer mentioned this pull request Aug 19, 2025

chore(deps): update dependency @vitejs/plugin-react to 5.0.1 stacksjs/ts-maps#51

Merged

1 task

claude bot mentioned this pull request Dec 8, 2025

chore(deps): update dependency @vitejs/plugin-react to v5.1.2 rknightion/paperless-ngx-dedupe#17

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(react): respect tsconfig jsxImportSource by default#726

fix(react): respect tsconfig jsxImportSource by default#726
hi-ogawa merged 11 commits intomainfrom
fix-tsconfig-jsxImportSource

hi-ogawa commented Aug 16, 2025 •

edited

Loading

Uh oh!

hi-ogawa Aug 16, 2025

Uh oh!

ArnaudBarre Aug 16, 2025

Uh oh!

hi-ogawa Aug 17, 2025 •

edited

Loading

Uh oh!

ArnaudBarre Aug 17, 2025

Uh oh!

hi-ogawa commented Aug 18, 2025

Uh oh!

sapphi-red commented Aug 18, 2025

Uh oh!

ArnaudBarre Aug 18, 2025

Uh oh!

hi-ogawa Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

hi-ogawa commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

hi-ogawa Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

ArnaudBarre Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArnaudBarre Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

hi-ogawa commented Aug 18, 2025

Uh oh!

sapphi-red commented Aug 18, 2025

Uh oh!

ArnaudBarre Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hi-ogawa commented Aug 16, 2025 •

edited

Loading

hi-ogawa Aug 17, 2025 •

edited

Loading