fix: fs serve only edit pathname (fixes #9148)#9173
Merged
patak-dev merged 2 commits intovitejs:mainfrom Jul 18, 2022
Merged
Conversation
sapphi-red
added
p3-minor-bug
patak-dev
reviewed
Jul 17, 2022
patak-dev
reviewed
Jul 17, 2022
| if ( | ||
| !ensureServingAccess( | ||
| slash(path.resolve(fsPathFromId(url))), | ||
| slash(path.resolve(fsPathFromId(pathname))), |
Member
There was a problem hiding this comment.
A problem here is that vite allows direct access to files with ? in the middle. See
So if we only check the pathname, we may not hit the correct entry in the safe list (
moduleGraph.safeModulesPath). So looks like the full URL needs to be used for ensureServingAccess
Member
Author
There was a problem hiding this comment.
It seems that that issue existed from before. sirv will only return /example when the request URL is /example?file.
So to fix this, IIUC we will need another middleware which does req.url = encodeURIComponent(decodeURI(req.url)) and calls sirv after that.
patak-dev
approved these changes
Jul 18, 2022
7 tasks
9 tasks
9 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I should have only encode/decode
pathnameand leave other parts as-is.#9148 was happening because
encodeURIComponent(decodeURIComponent('?'))is%3F.fixes #9148
refs #8804
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).