refactor: remove ?used inject in glob plugin#8900
Merged
patak-dev merged 4 commits intovitejs:mainfrom Jul 3, 2022
Merged
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
sapphi-red
changed the title
sapphi-red
commented
Jul 3, 2022
patak-dev
approved these changes
Jul 3, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This code was added by antfu/vite-plugin-glob@00a82b7.
But it is not needed because
?usedis injected byimport-analysiswhich runs at the end.Additional context
To fix_ #8245,
import-analysis-buildneeds to resolve id before deciding to inject?used.This PR is needed to dedupe that logic.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).