Skip to content

docs: correct pnpm command#8763

Merged
patak-cat merged 2 commits intovitejs:mainfrom
cassler:patch-1
Jun 24, 2022
Merged

docs: correct pnpm command#8763
patak-cat merged 2 commits intovitejs:mainfrom
cassler:patch-1

Conversation

@cassler
Copy link
Copy Markdown
Contributor

@cassler cassler commented Jun 24, 2022

Description

This PR corrects the pnpm getting started example. The instructions provided for scaffolding a template in pnpm do not set the template as expected. The extra double-dash is not needed in pnpm 7.

  • pnpm create vite -- --template vue <-- will prompt to select framework
  • pnpm create vite --template vue <-- correctly sets framework without prompting.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

The instructions provided for scaffolding a template in pnpm do you set the template as expected. The extra double-dash is not needed in pnpm 7.

- `pnpm create vite -- --template vue` <--  asks to select framework
- `pnpm create vite --template vue` <-- correctly sets framework without prompting.
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 24, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit c126dbf
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b606097523fb00082573ee

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Jun 24, 2022

Good catch! Would be great to update https://github.com/vitejs/vite/blob/main/packages/create-vite/README.md too

@patak-cat patak-cat changed the title docs(guide): corrected pnpm command docs: correct pnpm command Jun 24, 2022
@patak-cat patak-cat merged commit 8108b1b into vitejs:main Jun 24, 2022
@patak-cat
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants