fix: prevent crash when the pad amount is negative#8747
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jun 30, 2022
Merged
fix: prevent crash when the pad amount is negative#8747patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
If the start is less than the (count - lineLength) + 1 pad will be negative and cause the call to repeat on line 477 to crash with an uncaught RangeError.
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
patak-cat
approved these changes
Jun 23, 2022
Member
|
LGTM, it would be great to have a link to the project for reference if it is public. Or an explanation of the setup at least if not. |
bluwy
changed the title
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the start is less than the (count - lineLength) + 1 pad will be negative and cause the call to repeat on line 477 to crash with an uncaught RangeError. This caused Vite to crash when I was converting an app from Create React App to use Vite.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).This is my first time contributing to Vite (and nearly my first day using Vite), so please let me know if I've missed any steps or need to add anything.