chore!: update rollup commonjs plugin to v22 #8743
Merged
patak-dev merged 13 commits intovitejs:mainfrom Jun 24, 2022
Merged
Conversation
Well, the built bundle doesn't work yet. Blocked by rollup/plugins#1180
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
haoqunjiang
commented
Jun 23, 2022
Member
|
IIUC #7894 was failing in our test cases. Shouldn't we merge this if the vite CI passes with all playgrounds using |
Member
Author
|
Ah, thanks for the reminder. I forgot the tests currently aren't testing |
…so that it can correctly transpile `require` to `import *`
Member
Author
|
Tests are added and passed! Huge thanks to @lukastaegert for the quick release of the patch! |
patak-dev
reviewed
Jun 24, 2022
We'll move it to the ecosystem-ci instead
patak-dev
approved these changes
Jun 24, 2022
This was referenced Jun 24, 2022
7 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked a commit from @sapphi-red in #7894
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).