feat: export esbuildVersion and rollupVersion#8675
Merged
patak-dev merged 2 commits intovitejs:mainfrom Jun 20, 2022
Merged
Conversation
patak-dev
previously approved these changes
Jun 20, 2022
Member
|
Maybe we should do the same with rollup? |
Member
Author
|
Added rollup one too. 👍 |
patak-dev
approved these changes
Jun 20, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
esbuild does not accept passing unknown options.
For example, #8674 does not work with 0.14.41 or below because
logOverridedoes not exist.By exporting this, plugins can use it to conditionally set esbuild options.
This will reduce peer dependency bumps.
AFAIK it could also be obtained by the code below, but it is complicated.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).