Skip to content

Comments

fix(plugin-react): set this-is-undefined-in-esm to silent if classic runtime (fixes #8644)#8674

Merged
patak-dev merged 1 commit intovitejs:mainfrom
sapphi-red:fix/react-this-is-undefined-silent
Jun 20, 2022
Merged

fix(plugin-react): set this-is-undefined-in-esm to silent if classic runtime (fixes #8644)#8674
patak-dev merged 1 commit intovitejs:mainfrom
sapphi-red:fix/react-this-is-undefined-silent

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 20, 2022

Description

For automatic runtime it was fixed upstream (evanw/esbuild@0905d85).
But for classic runtime it still happens (evanw/esbuild#2328 (comment)).

This PR sets esbuild.logOverride['this-is-undefined-in-esm'] = 'silent' automatically when classic runtime is used.

This PR only works with esbuild 0.14.42+.
Vite 3.0.0-alpha.11+ requires 0.14.43 so it is safe.

"esbuild": "^0.14.43",

fixes #8644

Additional context

related: evanw/esbuild#2328


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) plugin: react labels Jun 20, 2022
@sapphi-red sapphi-red changed the title fix(plugin-react): set this-is-undefined-in-esm to silent if classic runtime (#8644) fix(plugin-react): set this-is-undefined-in-esm to silent if classic runtime (fixes #8644) Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-edge-case Bug, but has workaround or limited in scope (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vite] warning: Top-level "this" will be replaced with undefined since this file is an ECMAScript module

2 participants