feat!: bump minimum node version to 14.18.0#8662
Merged
patak-dev merged 1 commit intovitejs:mainfrom Jun 19, 2022
bluwy:bump-node-version
Merged
feat!: bump minimum node version to 14.18.0#8662patak-dev merged 1 commit intovitejs:mainfrom bluwy:bump-node-version
patak-dev merged 1 commit intovitejs:mainfrom
bluwy:bump-node-version
Conversation
patak-dev
approved these changes
Jun 19, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump Vite to node >=14.18.0
Additional context
Mostly find + replace. Hopefully I didn't miss anything 😬
Ref #8309 (comment), that
fs.rmSyncrequires node 14.14.node:protocols withrequire()requires `node 14.18.Ref https://twitter.com/bluwyoo/status/1538224383507845120, a poll is made about whether users are mindful of the version change. And a majority leans on "any version works", followed by 14.18 being fine for them.
Thought I'd separate this change from #8309 so it's easier to review.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).