Skip to content

refactor: type client maps#8626

Merged
patak-cat merged 3 commits intovitejs:mainfrom
sapphi-red:refactor/type-client-maps
Jun 20, 2022
Merged

refactor: type client maps#8626
patak-cat merged 3 commits intovitejs:mainfrom
sapphi-red:refactor/type-client-maps

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

  • Add stricter types to src/client/client.ts.
  • Update docs to be more accurate

refs #8625

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Jun 17, 2022
@patak-cat patak-cat merged commit cf87882 into vitejs:main Jun 20, 2022
@sapphi-red sapphi-red deleted the refactor/type-client-maps branch June 20, 2022 07:15
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Jun 21, 2022
patak-cat pushed a commit that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants