fix: dont handle sigterm in middleware mode#8550
Merged
patak-cat merged 3 commits intovitejs:mainfrom Jun 12, 2022
bluwy:fix-sigterm-middleware
Merged
fix: dont handle sigterm in middleware mode#8550patak-cat merged 3 commits intovitejs:mainfrom bluwy:fix-sigterm-middleware
patak-cat merged 3 commits intovitejs:mainfrom
bluwy:fix-sigterm-middleware
Conversation
bluwy
added
the
p2-nice-to-have
patak-cat
reviewed
Jun 12, 2022
Member
|
About the breaking change bit, we could consider this a bug fix. Maybe we need an advanced section in the migration guide targeted at integration and framework maintainers so we can at least add a point about this change (like bug fixes that may require special attention) |
patak-cat
reviewed
Jun 12, 2022
Co-authored-by: patak <[email protected]>
patak-cat
approved these changes
Jun 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #7627
Additional context
Not sure if this is considered breaking, but we made similar changes in the past in minors, e.g. #4232
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).