feat: treat Astro file scripts as TS#8151
Merged
patak-dev merged 2 commits intovitejs:mainfrom May 13, 2022
Merged
Conversation
This updates the import scanner to treat `<script>` tags inside of `.astro` files as TypeScript and not JS. In Astro plain scripts can contain TypeScript and this changes prevents error messages coming from the import scanner.
Contributor
Author
|
Looks like I broke all the things, will fix 😀 |
Contributor
Author
|
@patak-dev Tests are fixed |
patak-dev
added
the
p3-downstream-blocker
patak-dev
approved these changes
May 12, 2022
Member
|
I don't think this is a good long-term solution. We need to find a way to let frameworks configure Vite instead of adding patches in Core. But I still think we should merge this PR while we define and implement this API. |
bluwy
approved these changes
May 13, 2022
antfu
changed the title
patak-dev
pushed a commit
that referenced
this pull request
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the import scanner to treat
<script>tags inside of.astrofiles as TypeScript and not JS. In Astro plain scripts can contain TypeScript and this changes prevents error messages coming from the import scanner.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).