Merged
Conversation
sapphi-red
previously approved these changes
Apr 27, 2022
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
I checked WebAssembly, Worker, SharedWorker type exists in dom and webworker.
https://github.com/microsoft/TypeScript/blob/main/lib/lib.dom.d.ts
https://github.com/microsoft/TypeScript/blob/main/lib/lib.webworker.d.ts
Also I think this approach makes sense.
bluwy
previously approved these changes
Apr 27, 2022
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
This looks like a good solution to me too. I think we could merge in Vite 3 to not accidentally break existing project typechecking.
bluwy
added
the
p2-nice-to-have
Member
|
Should we add a note in the docs about how to let users add dom / webworker in tsconfig.json to determine env? |
bluwy
reviewed
May 5, 2022
Co-authored-by: Bjorn Lu <[email protected]>
patak-cat
approved these changes
May 5, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: #3905
Additional context
I remove the
/// <reference lib="dom" />, it can run. I think we can remove it. Let users add dom / webworker intsconfig.jsonto determine env. And the create-vite is also define{"lib": ["dom"]}What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).