Skip to content

fix: use NODE_ENV in optimizer#7673

Merged
patak-dev merged 1 commit intovitejs:mainfrom
bluwy:fix-optimizer-node-env
Apr 27, 2022
Merged

fix: use NODE_ENV in optimizer#7673
patak-dev merged 1 commit intovitejs:mainfrom
bluwy:fix-optimizer-node-env

Conversation

@bluwy
Copy link
Member

@bluwy bluwy commented Apr 11, 2022

Description

Use process.env.NODE_ENV too for esbuild define object. Similar to the define plugin:

'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV || config.mode),

Additional context

Found this issue at https://github.com/vitejs/vite/pull/7246/files#r846999746

While optimizing is for dev only, if we set mode to something else, it could affect define process.env.NODE_ENV which doesn't seem right to me.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 11, 2022
@patak-dev patak-dev requested a review from aleclarson April 11, 2022 20:05
@patak-dev patak-dev merged commit 50672e4 into vitejs:main Apr 27, 2022
@bluwy bluwy deleted the fix-optimizer-node-env branch April 27, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants