fix(css): include inline css module in bundle (fix #6984,#7552)#7591
Merged
patak-dev merged 1 commit intovitejs:mainfrom Apr 4, 2022
Merged
fix(css): include inline css module in bundle (fix #6984,#7552)#7591patak-dev merged 1 commit intovitejs:mainfrom
patak-dev merged 1 commit intovitejs:mainfrom
Conversation
patak-dev
approved these changes
Apr 3, 2022
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
LGTM, thanks also for expanding the condition. It is interesting that we have been returning modulesCode even when it is not used, this could potentially fix other issues (like duplicated CSS that esbuild has issues tree-shacking).
We can do it in another PR, but we may want to create a getModulesCode() function so we can call it for the dev branch, but only for the build branch when it is actually going to be needed.
Member
|
may be there are same with #6996 ? 👀 |
Member
Author
|
Oh I failed to find your PR. I think this PR is same with it. |
sapphi-red
changed the title
Member
Member
|
may be this PR cover my test 😊. so let it forward. |
poyoho
approved these changes
Apr 4, 2022
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Apr 19, 2022
9 tasks
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
May 2, 2022
7 tasks
7 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7552.
The issue title mentions SCSS, but it also happens with CSS.
fixes #6984
fixes #7552
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).