feat: add fixStacktrace option to ssrLoadModule#7048
Merged
patak-cat merged 1 commit intovitejs:mainfrom Feb 25, 2022
Merged
Conversation
4 tasks
benmccann
added
feat: ssr
p3-downstream-blocker
benmccann
force-pushed
the
fixStacktrace
branch
from
928bbfe to
3cb03d5
Compare
benmccann
force-pushed
the
fixStacktrace
branch
from
3cb03d5 to
7e91eb7
Compare
Member
|
Interesting that an unused |
patak-cat
approved these changes
Feb 25, 2022
Member
|
We discussed this PR today with the team and we think it is good to go forward with it 👍🏼 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #7046
Additional context
We've gotten a number of bug reports in SvelteKit about stack traces being incorrect. It turns out that's because Vite fixes the stack traces and then we fix them again. While conceptually we should be able to address this purely in our own code, in practice it's been quite difficult given the way our code is currently structured and the number of different places we call
ssrLoadModule. We'd like to just be able to wrap all the code in a singletry/catch, but without this feature would need to break it into about fifteen different blocks across different classes.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).