fix: sequential injection of tags in transformIndexHtml (#5851)#6901
Merged
patak-cat merged 3 commits intovitejs:mainfrom Jun 14, 2022
Merged
fix: sequential injection of tags in transformIndexHtml (#5851)#6901patak-cat merged 3 commits intovitejs:mainfrom
patak-cat merged 3 commits intovitejs:mainfrom
Conversation
Contributor
|
same question, can't wait. |
Contributor
Author
|
@tyouzu1 As a workaround, you can currently use the |
Contributor
Already seen. No test yet. Thanks anyway |
bluwy
added
feat: html
p2-to-be-discussed
Member
|
I think this makes sense, it is already added for discussion in a team meeting. We'll try to get to it before the v3 release. |
patak-cat
added
p3-downstream-blocker
Member
|
Just to clarify. This PR changes the order slightly. For example, if there are two plugins like this: {
plugins: [
{
name: 'hook1',
transformIndexHtml(html) {
return [
{ tag: 'meta', children: 'hook1-pre', injectTo: 'head-prepend' },
{ tag: 'meta', children: 'hook1', injectTo: 'head' }
]
}
},
{
name: 'hook2',
transformIndexHtml(html) {
return [
{ tag: 'meta', children: 'hook2-pre', injectTo: 'head-prepend' },
{ tag: 'meta', children: 'hook2', injectTo: 'head' }
]
}
}
]
}<!-- output before this PR -->
<head>
<meta>hook1-pre</meta>
<meta>hook2-pre</meta>
<meta>hook1</meta>
<meta>hook2</meta>
</head>
<!-- output after this PR -->
<head>
<meta>hook2-pre</meta>
<meta>hook1-pre</meta>
<meta>hook1</meta>
<meta>hook2</meta>
</head> |
sapphi-red
approved these changes
Jun 14, 2022
patak-cat
approved these changes
Jun 14, 2022
Member
patak-cat
left a comment
patak-cat
left a comment
There was a problem hiding this comment.
The new order is what I would expect 👍🏼
I would consider the order change a bug fix.
patak-cat
changed the title
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Jun 14, 2022
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Jun 14, 2022
7 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The built-in
htmlplugin provides atransformIndexHtmlhook for all plugins, which inputs contents ofindex.htmland outputs modified contents and some tags to inject. But alltagsto inject are injected after all plugins'transformIndexHtmlhook, so tags injected by previous plugins are not visible to next ones.It closes #5851.
Additional context
I changed the code to handle tags injection after each plugin's hook, so the performance inevitably degrades. Is it acceptable? If not, should we use other ways such as adding another parameter to
transformIndexHtmlto receive tags that previous plugins want to inject?What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).