docs: improve instructions for testing local changes against other packages#6084
Merged
patak-cat merged 3 commits intovitejs:mainfrom Dec 12, 2021
Merged
docs: improve instructions for testing local changes against other packages#6084patak-cat merged 3 commits intovitejs:mainfrom
patak-cat merged 3 commits intovitejs:mainfrom
Conversation
patak-cat
previously approved these changes
Dec 12, 2021
Contributor
|
isn't this option only for monorepos or mostly helpful for monorepo? pnpm link have worked for me for repos which are not monorepo |
Collaborator
Author
|
This option will work on any pnpm repo. It does not need to be a monorepo with multiple packages - though it will also work in those circumstances
Do you mean that it will work also for npm and yarn repos? |
Contributor
dont think so. when I used pnpm link on a repo which didn't use pnpm, I changed to pnpm
ah okay. thanks for letting me know |
Member
|
Could you correct the linting error? |
patak-cat
approved these changes
Dec 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pnpm linkhas never worked for me and it might be less clear to list two ways. Forpnpm.overrides, there was a key step missing, which is that Vite needs to be specified in the rootpackage.jsonand not in a sub-package'spackage.jsonAdditional context
I've never been able to test Vite against SvelteKit up until now. Thanks to some help from @bluwy on Discord I finally got it figured out. I thought it'd make sense to update these docs for others
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).