Skip to content

fix: ws types#6083

Merged
patak-cat merged 4 commits intovitejs:mainfrom
Niputi:fix/ws-types
Dec 12, 2021
Merged

fix: ws types#6083
patak-cat merged 4 commits intovitejs:mainfrom
Niputi:fix/ws-types

Conversation

@Niputi
Copy link
Copy Markdown
Contributor

@Niputi Niputi commented Dec 12, 2021 •
edited
Loading

Description

fix: #6073

had to change export type in ws.d.ts to get vite building.
have been confirmed by @bluwy to be working with svelte kit

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi changed the title Fix/ws types fix: types Dec 12, 2021
@Niputi
Copy link
Copy Markdown
Contributor Author

Niputi commented Dec 12, 2021

failing test looks unrelated

@Niputi Niputi requested a review from patak-cat December 12, 2021 16:02
@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Dec 12, 2021

Re-running jobs

patak-cat
patak-cat approved these changes Dec 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this 👍🏼

@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Dec 12, 2021

Using @bluwy as second approval here (as @Niputi commented, this has been testing by him in SvelteKit)
This also reverts the types to their prev state, so we have been using this already in the past

@patak-cat patak-cat changed the title fix: types fix: ws types Dec 12, 2021
@patak-cat patak-cat merged commit 1ded1a8 into vitejs:main Dec 12, 2021
@Niputi Niputi deleted the fix/ws-types branch December 12, 2021 16:16
@patak-cat patak-cat mentioned this pull request Dec 13, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ws types incorrectly bundled

2 participants

@Niputi @patak-cat