Skip to content

chore(deps): massive major deps update#5574

Merged
patak-cat merged 18 commits intomainfrom
massive-deps-update
Nov 7, 2021
Merged

chore(deps): massive major deps update#5574
patak-cat merged 18 commits intomainfrom
massive-deps-update

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

@Shinigami92 Shinigami92 commented Nov 6, 2021 •
edited
Loading

Description

This is a try to update all missing dependencies.
This could potentially introduce hidden breaking changes 🤔 So a careful review and maybe a beta version is needed to test the future stability.

Additional context

Some deps could still not be updated successfully due to major breaking changes:

  • ws
    • needs new TS type updates
  • cac
  • estree-walker
  • strip-ansi
    • needs esm

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority) labels Nov 6, 2021
@Shinigami92 Shinigami92 self-assigned this Nov 6, 2021
Shinigami92
Shinigami92 commented Nov 6, 2021
View reviewed changes
Comment thread packages/vite/package.json
Shinigami92
Shinigami92 commented Nov 6, 2021
View reviewed changes
Comment thread packages/vite/src/node/ssr/ssrModuleLoader.ts
@Shinigami92
Copy link
Copy Markdown
Member Author

Shinigami92 commented Nov 6, 2021

For protocol: https://stackoverflow.com/a/64723740/6897682

@Shinigami92
Copy link
Copy Markdown
Member Author

Shinigami92 commented Nov 6, 2021

Fuuu**** 😡 I don't know how to solve this. Don't want to downgrade to v15 😕

    scripts/jestPerTestSetup.ts:59:23 - error TS2339: Property 'page' does not exist on type 'typeof globalThis'.

    59   const page = global.page
                             ~~~~

@Shinigami92
Copy link
Copy Markdown
Member Author

Shinigami92 commented Nov 6, 2021

Seems we need to switch to esm soon...

@Shinigami92 Shinigami92 mentioned this pull request Nov 6, 2021
Merged
9 tasks
@Shinigami92
Copy link
Copy Markdown
Member Author

Shinigami92 commented Nov 6, 2021

SOME GREEN TICKS ✔️ finally 🥳

... starting with some migrations and cleanups 😃

Shinigami92
Shinigami92 commented Nov 6, 2021
View reviewed changes
Comment thread packages/plugin-vue/README.md
@Shinigami92 Shinigami92 requested a review from patak-cat November 6, 2021 22:33
@Shinigami92 Shinigami92 requested a review from Niputi November 6, 2021 22:33
@Shinigami92 Shinigami92 marked this pull request as ready for review November 6, 2021 22:37
Niputi
Niputi reviewed Nov 6, 2021
View reviewed changes
Comment thread packages/vite/src/node/plugins/css.ts
@patak-cat patak-cat merged commit 211f183 into main Nov 7, 2021
@Shinigami92 Shinigami92 deleted the massive-deps-update branch November 7, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

+1 more reviewer

@Niputi Niputi Niputi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Shinigami92 Shinigami92

Labels

dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shinigami92 @patak-cat @Niputi