Skip to content

chore(deps): update dependency ws to v8#5540

Merged
patak-cat merged 1 commit intovitejs:mainfrom
Niputi:feat/upgrade-ws
Nov 7, 2021
Merged

chore(deps): update dependency ws to v8#5540
patak-cat merged 1 commit intovitejs:mainfrom
Niputi:feat/upgrade-ws

Conversation

@Niputi
Copy link
Copy Markdown
Contributor

@Niputi Niputi commented Nov 3, 2021

Description

closes: #4471

it's not possible to import OPEN from ws as it's not exported from .mjs version in ws which is why I made comment to explain that the number 1 is the state open

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-cat
patak-cat previously approved these changes Nov 4, 2021
@Shinigami92
Copy link
Copy Markdown
Member

rebase this after merge of #5574

@Shinigami92 Shinigami92 self-requested a review November 6, 2021 21:28
@Shinigami92 Shinigami92 added the dependencies Pull requests that update a dependency file label Nov 6, 2021
@patak-cat patak-cat merged commit 2efc1e5 into vitejs:main Nov 7, 2021
@Niputi Niputi deleted the feat/upgrade-ws branch November 7, 2021 16:23
@benmccann benmccann mentioned this pull request Dec 11, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants