feat: enable generatedCode: 'es2015' for rollup build#5018
Merged
patak-cat merged 7 commits intovitejs:mainfrom May 13, 2022
Merged
feat: enable generatedCode: 'es2015' for rollup build#5018patak-cat merged 7 commits intovitejs:mainfrom
generatedCode: 'es2015' for rollup build#5018patak-cat merged 7 commits intovitejs:mainfrom
Conversation
haoqunjiang
reviewed
Sep 22, 2021
antfu
force-pushed
the
feat/rollup-build
branch
3 times, most recently
from
ae0ee6d to
739317b
Compare
antfu
force-pushed
the
feat/rollup-build
branch
from
739317b to
1f3b5b6
Compare
|
support es5? |
It could. for old browser, we could use AMD/requirejs #5754 |
Member
|
Member
|
@antfu we could merge this one, no? Tests are passing, was there an issue that prevented us from using it? I can't recall now. |
Member
Author
|
We could merge it as long as the tests are passing I believe (it was failing for some reason) |
Member
|
I'm not sure about the failing test in the past, but I have pushed a commit which fixes the current failing test. |
Member
Author
|
Thanks. And it seems like I can't approve my own PR 😅 |
bluwy
reviewed
May 13, 2022
patak-cat
approved these changes
May 13, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See https://twitter.com/lukastaegert/status/1440543481059938305
Additional context
Awaits #5045
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).