test: SSR externals on Windows #4980#4986
Merged
patak-dev merged 4 commits intovitejs:mainfrom Sep 19, 2021
untp:example-external-component
Merged
test: SSR externals on Windows #4980#4986patak-dev merged 4 commits intovitejs:mainfrom untp:example-external-component
patak-dev merged 4 commits intovitejs:mainfrom
untp:example-external-component
Conversation
patak-dev
approved these changes
Sep 19, 2021
Contributor
Author
|
Before #4980 After #4980 |
Shinigami92
approved these changes
Sep 19, 2021
patak-dev
approved these changes
Sep 19, 2021
Member
|
Thanks a lot for taking the time to add the test cases and provide before and after results! I hope we see you around again 👍🏼 |
ygj6
pushed a commit
to ygj6/vite
that referenced
this pull request
Sep 22, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for #4980