Skip to content

Comments

fix(css): revert return sourcemap in vite:css transform (#4880)#4951

Merged
patak-dev merged 1 commit intovitejs:mainfrom
dominikg:fix/revert-css-sourcemap
Sep 16, 2021
Merged

fix(css): revert return sourcemap in vite:css transform (#4880)#4951
patak-dev merged 1 commit intovitejs:mainfrom
dominikg:fix/revert-css-sourcemap

Conversation

@dominikg
Copy link
Contributor

This reverts commit 015290a.

(fixes #4939)

alternative to #4950

Description

as mentioned in #4950, adding proper css sourcemap support is a lot more work, so revert this to avoid #4939 until we got there.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: css p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sourcemap is likely to be incorrect: a plugin (undefined) was used to transform files...

3 participants