Skip to content

Comments

fix(css): return sourcemap in vite:css transform#4880

Merged
antfu merged 1 commit intovitejs:mainfrom
dominikg:fix/css-sourcemap
Sep 13, 2021
Merged

fix(css): return sourcemap in vite:css transform#4880
antfu merged 1 commit intovitejs:mainfrom
dominikg:fix/css-sourcemap

Conversation

@dominikg
Copy link
Contributor

@dominikg dominikg commented Sep 8, 2021

Description

return actual sourcemap for css transform instead of a dummy

Additional context

may fix #649

Note i didn't do any further analysis besides running the tests, but this seems like a trivial change for the better, can't get more broken than that dummy.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dominikg
Copy link
Contributor Author

dominikg commented Sep 8, 2021 •
edited
Loading

There was a previous attempt at this aimed at vite1 that was closed #659 and there may be other things to consider that i missed.
Thanks to @bluwy who reminded me about this.

patak-dev
patak-dev approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this wasn't caught before by someone

@Shinigami92 Shinigami92 added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Sep 8, 2021
@antfu antfu merged commit 015290a into vitejs:main Sep 13, 2021
@hex-ci
Copy link
Contributor

hex-ci commented Sep 15, 2021

This PR seems to have an impact on the vite-plugin-vue2 plugin. If you upgrade to Vite 2.5.7, a "Sourcemap is likely to be incorrect" warning will be reported during build. If you downgrade to Vite 2.5.6, there will be no warning, only downgrade vite-plugin-vue2 There are always warnings. I haven't figured out the specific reason, and I need help, thank you.

@patak-dev
Copy link
Member

patak-dev commented Sep 15, 2021

@hex-ci did you open an issue in vite-plugin-vue2? Maybe this is something to be solved there? Please link the issue for reference here

@hex-ci hex-ci mentioned this pull request Sep 15, 2021
Closed
@hex-ci
Copy link
Contributor

hex-ci commented Sep 15, 2021

@hex-ci did you open an issue in vite-plugin-vue2? Maybe this is something to be solved there? Please link the issue for reference here

I created an issue: underfin/vite-plugin-vue2#132

@hex-ci hex-ci mentioned this pull request Sep 16, 2021
Closed
7 tasks
@hex-ci
Copy link
Contributor

hex-ci commented Sep 16, 2021

@patak-js The problem mentioned in #4939 seems to affect not only Vue 2, but also Vue 3.

@patak-dev
Copy link
Member

patak-dev commented Sep 16, 2021

Oh, I think you should also open an issue here to track it

dominikg added a commit to dominikg/vite that referenced this pull request Sep 16, 2021
@dominikg
Revert "fix(css): return sourcemap in vite:css transform (vitejs#4880)"
7d55e61 
This reverts commit 015290a.
patak-dev pushed a commit that referenced this pull request Sep 16, 2021
@dominikg
fix(css): revert return sourcemap in vite:css transform (#4880) (#4951)
72cb33e
antfu pushed a commit that referenced this pull request Sep 17, 2021
@dominikg @antfu
fix(css): revert return sourcemap in vite:css transform (#4880) (#4951)
17feb38
@bluwy bluwy mentioned this pull request Sep 25, 2021
Closed
@dominikg dominikg mentioned this pull request Sep 25, 2021
Open
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@dominikg @aleclarson
fix(css): return sourcemap in vite:css transform (vitejs#4880)
6385251
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@dominikg @aleclarson
fix(css): revert return sourcemap in vite:css transform (vitejs#4880) (…
cd5708a 
…vitejs#4951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

feat: css p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The css sourceMap not work

6 participants

@dominikg @hex-ci @patak-dev @bluwy @Shinigami92 @antfu