fix: crash when importing component with no script tag#46
Merged
yyx990803 merged 1 commit intovitejs:masterfrom May 4, 2020
mathieumure:fix-test
Merged
fix: crash when importing component with no script tag#46yyx990803 merged 1 commit intovitejs:masterfrom mathieumure:fix-test
yyx990803 merged 1 commit intovitejs:masterfrom
mathieumure:fix-test
Conversation
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Nov 9, 2024
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Nov 11, 2024
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Nov 13, 2024
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Nov 15, 2024
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Nov 28, 2024
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Nov 30, 2024
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Jan 6, 2025
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Feb 18, 2025
hi-ogawa
pushed a commit
to hi-ogawa/vite
that referenced
this pull request
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash when importing a vue component with no script tag. It also fixes the tests.
This was caused by a parsing error:
which is not JS valid. So I add the following to be