fix: do not end process in middleware mode, fix #4196#4232
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jul 13, 2021
Merged
fix: do not end process in middleware mode, fix #4196#4232patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
patak-cat
approved these changes
Jul 13, 2021
Shinigami92
approved these changes
Jul 13, 2021
antfu
approved these changes
Jul 13, 2021
haoqunjiang
approved these changes
Jul 13, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4196.
It doesn't make much sense to end the vite process based on stdin when vite is running in middleware mode, as pointed out in #4196.
Additional context
I based the original check for CI off of what create-react-app does, but that project does not have a specific "middleware mode". I think it makes sense to include both of these checks, until/unless we can find a good way to detect running in docker/CI/container/non-interactive terminal (which is harder than it seems like it should be).
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).