fix: use path type import, fix #4028#4031
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jun 30, 2021
Merged
Conversation
9 tasks
GrygrFlzr
approved these changes
Jun 30, 2021
patak-cat
approved these changes
Jun 30, 2021
8 tasks
6 tasks
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #4029.
This seems to be a simpler way to fix the issue, and I've verified that it does in fact pass CI in linux in my own project.
Additional context
I believe that the
typedirective is for pointing to the name of a types package, and it just-so-happened to work in case-insensitive OSes. But from what we are trying to do, after reading https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-path-, thepathdirective seems more appropriate, and does not suffer from being made lowercase.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).