fix: rename type files as lowercase (fixes #4028)#4029
Closed
IanVS wants to merge 1 commit intovitejs:mainfrom
Closed
fix: rename type files as lowercase (fixes #4028)#4029IanVS wants to merge 1 commit intovitejs:mainfrom
IanVS wants to merge 1 commit intovitejs:mainfrom
Conversation
8 tasks
Contributor
Author
|
Replaced by #4031 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the files in
vite/typesto all be lowercase, so that they can be referenced in typescript triple-slash directives, which for some reason seem to always lowercase the provided path.Additional context
I think it's likely a bug in typescript, but I don't think we can hold our breath on a change upstream, and this doesn't seem like a horrible workaround.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).I couldn't find a good way to write tests for this, but I did build and copy the results into my node_modules of my project, and verified that it solves the issue I was having.