Conversation
Member
|
@GrygrFlzr for the rest of the types, we are duplicating the definitions instead of importing them. I am fine if this is a better approach and we start moving towards using imports, but if we plan to leave things as is, shouldn't we duplicate also these definitions to be consistent? Or is there something different from these ones in particular? |
Member
Author
|
As suggested, I've swapped to consistently importing in order to remove the duplicated types. |
Contributor
|
I copied these changes into my |
patak-cat
approved these changes
Jun 28, 2021
antfu
approved these changes
Jun 28, 2021
This was referenced Jun 29, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4002.
Thus, the addition of imports in the
client.d.tsin #3638:Is improper and invalidates
client.d.tsas an ambient declaration.Instead, we have to import types this way:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).Ideally, include relevant tests that fail without this PR but pass with it.