Skip to content

Comments

test: add test suite to stabilize ssr frameworks#2740

Closed
brillout wants to merge 9 commits intovitejs:mainfrom
brillout:test-2390
Closed

test: add test suite to stabilize ssr frameworks#2740
brillout wants to merge 9 commits intovitejs:mainfrom
brillout:test-2390

Conversation

@brillout
Copy link
Contributor

@brillout brillout commented Mar 27, 2021

Tests #2390 #1875 amongst others.

The plan here is to have a test suite that stabilizes the foundation on which Vite SSR frameworks are build on.

One possible downside of this PR is that it can be seen as redundant to playgroud/ssr-vue / playground-ssr-react. But, IMO, the many subtle differences between directly using the Vite API and using a SSR framework which uses the Vite API justifies this PR.

Letting know folks who build Vite SSR frameworks @egoist @frandiox @galvez @dominikg @GrygrFlzr @Rich-Harris

The tests fail because #2390 is not merged yet. They will go green once 2390 is merged.

@brillout brillout mentioned this pull request Mar 27, 2021
Merged
Shinigami92
Shinigami92 reviewed Mar 27, 2021
View reviewed changes
@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Mar 28, 2021
Shinigami92
Shinigami92 previously approved these changes Mar 28, 2021
View reviewed changes
@Shinigami92
Copy link
Member

Shinigami92 commented Mar 28, 2021

So the code itself is looking okay, but there are now failing tests
Please try to fix them
If you need help, I can add the help wanted label 🙂 so other contributors can find this PR more easily

@brillout
Copy link
Contributor Author

brillout commented Mar 28, 2021

The tests fail because #2390 is not merged yet. They will go green once 2390 is merged.

:-)

If you need help, I can add the help wanted label 🙂 so other contributors can find this PR more easily

I'm good but thanks. I CC'd framework authors so that they are aware of the test suite; would be nice for the test suite to grow.

Thanks for the review :-).

@brillout brillout force-pushed the test-2390 branch 4 times, most recently from e3b8dac to 57d94e3 Compare April 11, 2021 14:55
@Shinigami92 Shinigami92 marked this pull request as draft April 11, 2021 15:58
@Shinigami92 Shinigami92 requested a review from patak-dev April 23, 2021 09:10
@patak-dev
Copy link
Member

patak-dev commented Apr 23, 2021

Looks like the tests are still failing in windows and increasing the timeout doesn't help here. @nihalgonsalves created an issue for the issues with the test suite #3106

@brillout
Copy link
Contributor Author

brillout commented Apr 23, 2021

increasing the timeout doesn't help here

Thanks ❤️ I was actually wondering about this. And thanks for the pointer to Nihal's GH issue.

@nihalgonsalves The errors are (node:3144) UnhandledPromiseRejectionWarning: page.click: Browser has been closed and page.$: Browser has been closed; could it be linked to your changes? (I rebased the PR on main.)

@brillout
Copy link
Contributor Author

brillout commented May 4, 2021 •
edited
Loading

Still getting timeouts and (node:6920) UnhandledPromiseRejectionWarning: page.$: Browser has been closed on windows.

EDIT: tried again - still no luck.

@brillout
Copy link
Contributor Author

brillout commented Jul 16, 2021

Still no luck on windows.

@benmccann benmccann mentioned this pull request Aug 4, 2021
Closed
@brillout
Copy link
Contributor Author

brillout commented Jan 23, 2022

Closing this in favor of https://github.com/vitejs/vite-ecosystem-ci

@brillout brillout closed this Jan 23, 2022
@brillout brillout deleted the test-2390 branch September 18, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-dev patak-dev Awaiting requested review from patak-dev

1 more reviewer

@Shinigami92 Shinigami92 Shinigami92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feat: ssr p1-chore Doesn't change code behavior (priority) test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brillout @Shinigami92 @patak-dev