fix(bundledDev): print build errors to the terminal when an HMR update fails#23024
Merged
sapphi-red merged 1 commit intoJul 24, 2026
Conversation
btea
approved these changes
Jul 24, 2026
btea
left a comment
Contributor
There was a problem hiding this comment.
Try to maintain consistent behavior across different modes.
sapphi-red
approved these changes
Jul 24, 2026
sapphi-red
deleted the
07-23-fix_bundleddev_print_build_errors_to_the_terminal_when_an_hmr_update_fails
branch
July 24, 2026 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In bundled dev mode (
experimental.bundledDev), when a file change breaks the build (for example an import path that cannot be resolved), the error is only shown in the browser overlay. The terminal prints nothing.Expected behavior is the same as normal dev mode: every failed build prints the error in the terminal, and after the file is fixed the terminal shows the recovery (
hmr update/page reload).The cause is that the two dev engine callbacks handle errors differently:
onOutputerror branch logs✘ Build errorto the terminal and sends the overlay.onHmrUpdateserror branch only sends the overlay.With the default rebuild strategy, a file change only generates HMR updates, so a failed rebuild goes through
onHmrUpdatesand the terminal stays silent.This PR adds the same
✘ Build errorlogging to theonHmrUpdateserror branch.Before:
After:
Also added a
serverLogsassertion to the existinghandle generate hmr patch errorplayground test. The assertion fails without this fix and passes with it.closes rolldown/rolldown#10136