fix(vite): scan is not resolving sub path import if used in a glob import#22006
Closed
kalvenschraut wants to merge 2 commits intovitejs:mainfrom
Closed
fix(vite): scan is not resolving sub path import if used in a glob import#22006kalvenschraut wants to merge 2 commits intovitejs:mainfrom
kalvenschraut wants to merge 2 commits intovitejs:mainfrom
Conversation
Member
|
Yeah, we should pass the option here. I've tweaked your change a bit in #22018. I hope you don't mind. |
Contributor
Author
|
I can't unfortunately due to it being on an org fork and not personal from my understanding I have tried but thanks for taking over idc much just wanted it fixed. Not attached to AI code https://github.com/orgs/community/discussions/5634 per the reason why I cant. Unless that is there on creation only and I just missed it. |
kalvenschraut
deleted the
fix/dep-scan-with-import-subpath-and-import-glob
branch
Member
|
Ah, I forgot about that limitation... I hope GitHub fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22005
I did use AI pretty heavily for this to find issue, make test case and fix. I have reviewed everything myself and looks fine to me. I am not entirely sure why this fixes it though, guessing things are passing in a 3rd parameter but this one case wasnt using it?