Skip to content

fix(worker): make worker output consistent with client and SSR#21871

Merged
sapphi-red merged 3 commits intovitejs:mainfrom
willfarrell:fix/worker-url-regression
Mar 19, 2026
Merged

fix(worker): make worker output consistent with client and SSR#21871
sapphi-red merged 3 commits intovitejs:mainfrom
willfarrell:fix/worker-url-regression

Conversation

@willfarrell
Copy link
Copy Markdown
Contributor

@willfarrell willfarrell commented Mar 15, 2026 •
edited
Loading

Use worker environment config for minify/sourcemap in bundleWorkerEntry

bundleWorkerEntry() reads config.build.minify and config.build.sourcemap from the caller's environment config instead of the worker's own environment config. During build, config.build is https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1877-L1879 — SSR gets minify: false, client gets minify: 'oxc'. Since workers are always bundled as client assets (via new BuildEnvironment('client', ...)), they should consistently use the client environment's build settings. Instead, they inherit whatever the caller happens to be.

This causes ?worker&url imports to produce different content hashes in SSR vs client builds. SSR renders HTML referencing the server-side hash, but only client-built files are served — resulting in 404s.

The fix

Replace config.build.minify and config.build.sourcemap with workerEnvironment.config.build.minify and workerEnvironment.config.build.sourcemap in the bundle.generate() call. The workerEnvironment is already a BuildEnvironment('client', ...) whose .config proxy resolves build.* from environments.client.build — which is stable regardless of the caller.

What other alternatives have you explored?

  • worker: { format: 'es' } in user config — doesn't help; the hash mismatch is caused by minification differences, not output format.
  • Post-build plugin to copy client files under server hash names — works as a user-land workaround but is fragile (hash parsing, timing issues with adapters) and doesn't fix the root cause.
  • ?url instead of ?worker&url — doesn't bundle dependencies, breaks at runtime.

Attention from reviewers

  • config.build.assetsDir (lines 219, 223, 227) also reads from the caller's config but doesn't cause hash mismatches since the default is 'assets' for all environments. Left unchanged to keep this PR minimal, but could be updated for consistency.
  • The existing TODO comment on line 188 (// TODO: should this be 'worker'?) suggests the team is already aware that worker environment naming may need revisiting. This fix works correctly with the current 'client' name.
  • PR code written by Claude Opus 4.6, reviewed by human

@sapphi-red sapphi-red changed the title fix: vite 8 regression to ?worker&url fix(worker): make worker output consistent with client and SSR Mar 16, 2026
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release feat: web workers labels Mar 16, 2026
sapphi-red
sapphi-red approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit 69454d7 into vitejs:main Mar 19, 2026
28 of 29 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 31, 2026
@renovate
Update dependency vite to v8
4de7c8a 
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | vite    | 7.3.1 | 8.0.3 |


## [v8.0.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-803-2026-03-26-small)

##### Features

- update rolldown to 1.0.0-rc.12 ([#22024](vitejs/vite#22024)) ([84164ef](vitejs/vite@84164ef))

##### Bug Fixes

- **html:** cache unfiltered CSS list to prevent missing styles across entries ([#22017](vitejs/vite#22017)) ([5464190](vitejs/vite@5464190))
- **module-runner:** handle non-ascii characters in base64 sourcemaps ([#21985](vitejs/vite#21985)) ([77c95bf](vitejs/vite@77c95bf))
- **module-runner:** skip re-import if the runner is closed ([#22020](vitejs/vite#22020)) ([ee2c2cd](vitejs/vite@ee2c2cd))
- **optimizer:** scan is not resolving sub path import if used in a glob import ([#22018](vitejs/vite#22018)) ([ddfe20d](vitejs/vite@ddfe20d))
- **ssr:** ssrTransform incorrectly rewrites `meta` identifier inside `import.meta` when a binding named `meta` exists ([#22019](vitejs/vite#22019)) ([cff5f0c](vitejs/vite@cff5f0c))

##### Miscellaneous Chores

- **deps:** bump picomatch from 4.0.3 to 4.0.4 ([#22027](vitejs/vite#22027)) ([7e56003](vitejs/vite@7e56003))

##### Tests

- **html:** add tests for `getCssFilesForChunk` ([#22016](vitejs/vite#22016)) ([43fbbf9](vitejs/vite@43fbbf9))


## [v8.0.2](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-802-2026-03-23-small)

##### Features

- update rolldown to 1.0.0-rc.11 ([#21998](vitejs/vite#21998)) ([ff91c31](vitejs/vite@ff91c31))

##### Bug Fixes

- **deps:** update all non-major dependencies ([#21988](vitejs/vite#21988)) ([9b7d150](vitejs/vite@9b7d150))

##### Miscellaneous Chores

- **deps:** update dependency [@vitejs/devtools](https://github.com/vitejs/devtools) to ^0.1.5 ([#21992](vitejs/vite#21992)) ([b2dd65b](vitejs/vite@b2dd65b))


## [v8.0.1](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-801-2026-03-19-small)

##### Features

- update rolldown to 1.0.0-rc.10 ([#21932](vitejs/vite#21932)) ([b3c067d](vitejs/vite@b3c067d))

##### Bug Fixes

- **bundled-dev:** properly disable `inlineConst` optimization ([#21865](vitejs/vite#21865)) ([6d97142](vitejs/vite@6d97142))
- **css:** lightningcss minify failed when `build.target: 'es6'` ([#21933](vitejs/vite#21933)) ([5fcce46](vitejs/vite@5fcce46))
- **deps:** update all non-major dependencies ([#21878](vitejs/vite#21878)) ([6dbbd7f](vitejs/vite@6dbbd7f))
- **dev:** always use ESM Oxc runtime ([#21829](vitejs/vite#21829)) ([d323ed7](vitejs/vite@d323ed7))
- **dev:** handle concurrent restarts in `_createServer` ([#21810](vitejs/vite#21810)) ([40bc729](vitejs/vite@40bc729))
- handle `+` symbol in package subpath exports during dep optimization ([#21886](vitejs/vite#21886)) ([86db93d](vitejs/vite@86db93d))
- improve `no-cors` request block error ([#21902](vitejs/vite#21902)) ([5ba688b](vitejs/vite@5ba688b))
- use precise regexes for transform filter to avoid backtracking ([#21800](vitejs/vite#21800)) ([dbe41bd](vitejs/vite@dbe41bd))
- **worker:** `require(json)` result should not be wrapped ([#21847](vitejs/vite#21847)) ([0672fd2](vitejs/vite@0672fd2))
- **worker:** make worker output consistent with client and SSR ([#21871](vitejs/vite#21871)) ([69454d7](vitejs/vite@69454d7))

##### Miscellaneous Chores

- add changelog rearrange script ([#21835](vitejs/vite#21835)) ([efef073](vitejs/vite@efef073))
- **deps:** bump required `@vitejs/devtools` version to 0.1+ ([#21925](vitejs/vite#21925)) ([12932f5](vitejs/vite@12932f5))
- **deps:** update rolldown-related dependencies ([#21787](vitejs/vite#21787)) ([1af1d3a](vitejs/vite@1af1d3a))
- rearrange 8.0 changelog ([8e05b61](vitejs/vite@8e05b61))
- rearrange 8.0 changelog ([#21834](vitejs/vite#21834)) ([86edeee](vitejs/vite@86edeee))


## [v8.0.0](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#800-2026-03-12)

##### Features

- update rolldown to 1.0.0-rc.9 ([#21813](vitejs/vite#21813)) ([f05be0e](vitejs/vite@f05be0e))
- warn when `vite-tsconfig-paths` plugin is detected ([#21781](vitejs/vite#21781)) ([ada493e](vitejs/vite@ada493e))

##### Bug Fixes

- **deps:** update all non-major dependencies ([#21786](vitejs/vite#21786)) ([eaa4352](vitejs/vite@eaa4352))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@willfarrell @sapphi-red