fix(html): fix CSS missing when building with different seenCss context#21298
Closed
thy486 wants to merge 1 commit intovitejs:mainfrom
Closed
fix(html): fix CSS missing when building with different seenCss context#21298thy486 wants to merge 1 commit intovitejs:mainfrom
thy486 wants to merge 1 commit intovitejs:mainfrom
Conversation
Member
|
Would you extract this part of code and write unit tests? It would be great if you can do the extraction and add unit tests for #19143 in a separate PR first. |
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, CSS file cache was built based on seenCss state at that time. When multiple HTML entries process the same chunk, the cached CSS files may exclude files that were already in seenCss during first processing, causing those files to be missing in subsequent entries.
This fix introduces dirty chunk tracking to validate and rebuild cache when CSS files are detected as missing.
e.g.