Skip to content

fix(create-vite): support deno create command#20806

Merged
sapphi-red merged 2 commits into
vitejs:mainfrom
ptphongkmf:fix/incorrect-deno-cmd-for-tsrouter
Sep 22, 2025
Merged

fix(create-vite): support deno create command#20806
sapphi-red merged 2 commits into
vitejs:mainfrom
ptphongkmf:fix/incorrect-deno-cmd-for-tsrouter

Conversation

@ptphongkmf
Copy link
Copy Markdown
Contributor

@ptphongkmf ptphongkmf commented Sep 20, 2025 •
edited by bluwy
Loading

Description

fixes #20804

Finally got around to fixing the issue I reported in #20804

some caveats:

  • some option from tsrouter will not work, but this more of a tsrouter problem, not vite. Overall not an issue
◇  Installed dependencies
│
◇  Solid-UI commands complete
│
└  Your TanStack app is ready in 'TARGET_DIR'.

Use the following commands to start your app:
% cd TARGET_DIR
% deno task dev

Please check the README.md for information on testing, styling, adding routes, etc.

Errors were encountered during the creation of your app:

Command "npx solidui-cli@latest add button input" did not run successfully. Please run this manually in your project.

bluwy
bluwy reviewed Sep 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also take the opportunity to fix for npm exec too. I think the equivalent in deno is deno run -A npm:the-library .... (Passing -A here to allow all permissions since create-vite should also have all permissions at this point. I think it's fine?)

@bluwy bluwy changed the title fix: add custom create cmd for deno create-vite (fix #20804) fix(create-vite): support deno create command Sep 20, 2025
@ptphongkmf ptphongkmf force-pushed the fix/incorrect-deno-cmd-for-tsrouter branch from f6f61b7 to aaca258 Compare September 21, 2025 05:18
@ptphongkmf
Copy link
Copy Markdown
Contributor Author

ptphongkmf commented Sep 21, 2025

Maybe we can also take the opportunity to fix for npm exec too. I think the equivalent in deno is deno run -A npm:the-library .... (Passing -A here to allow all permissions since create-vite should also have all permissions at this point. I think it's fine?)

yeah that made sense, i also repaced init with run so users dont have to prompt y

bluwy
bluwy approved these changes Sep 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sapphi-red sapphi-red added feat: create-vite create-vite package trigger: preview p3-minor-bug An edge case that only affects very specific usage (priority) labels Sep 22, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 22, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/vite@20806

commit: ccfa2c2

sapphi-red
sapphi-red approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red merged commit a50a162 into vitejs:main Sep 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

feat: create-vite create-vite package p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect create tanstack-router command with deno

3 participants

@ptphongkmf @bluwy @sapphi-red