fix(ssr)!: don't access Object variable in ssr transformed code#19996
Merged
sapphi-red merged 9 commits intovitejs:mainfrom Jun 9, 2025
Merged
fix(ssr)!: don't access Object variable in ssr transformed code#19996sapphi-red merged 9 commits intovitejs:mainfrom
Object variable in ssr transformed code#19996sapphi-red merged 9 commits intovitejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objectconstructor is shadowed #19993I added
__vite_ssr_exportName__to runtime context so we can move outObject.definedPropertyfrom ssr transformed code.Since this breaks vite-node, I added a patch to add the same runtime context.(EDIT: updated to vitest 3.2 beta)This is likely hard to test on ecosystem ci since anyone using Vitest / vite-node breaks 🤔
I made a Vitest side PR (and package) so they can be tested if both overrides are setup vitest-dev/vitest#7925.
As seen in ecosystem-ci below, this change didn't break
vite-plugin-cloudflarenorvite-environment-examplesbecause their custom module runner usesObject.keys(context)andObject.values(context)without referencing exact context keys https://github.com/cloudflare/workers-sdk/blob/1cd30a554f00dfd7bff43bbd3e601bc67f7acb2b/packages/vite-plugin-cloudflare/src/runner-worker/module-runner.ts#L55-L69