fix(hmr): run HMR handler sequentially#19793
Merged
patak-dev merged 3 commits intovitejs:mainfrom Apr 11, 2025
Merged
Conversation
Member
Author
|
/ecosystem-ci run |
commit: |
|
📝 Ran ecosystem CI on
✅ nuxt, quasar, histoire, ladle, previewjs, marko, analogjs, sveltekit, rakkas, vite-plugin-vue, astro, qwik, vitest, vite-plugin-pwa, vitepress, unocss, vite-plugin-react-swc, react-router, vite-setup-catalogue, vite-plugin-svelte, vuepress, vite-plugin-cloudflare |
hi-ogawa
approved these changes
Apr 11, 2025
patak-dev
approved these changes
Apr 11, 2025
Member
patak-dev
left a comment
There was a problem hiding this comment.
I think we can merge this one in the minor
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the following flaky fail:
This fail was happening because multiple HMR event was processed concurrently.
This PR makes the HMR event handler to run sequentially. This makes the HMR behavior in browsers more aligned with the module runner.
I tested this locally with the following test:
refs #16307