feat: use host url to open browser#19414
Merged
bluwy merged 3 commits intovitejs:mainfrom Feb 20, 2025
Merged
Conversation
sapphi-red
added
the
p2-nice-to-have
sapphi-red
approved these changes
Feb 20, 2025
bluwy
approved these changes
Feb 20, 2025
Contributor
|
It's not working with |
Member
|
@BuptStEve please don't comment on merged PRs like this. If your use case isn't covered by this PR, or you found a bug in this feature please open a new issue with proper context and a minimal reproduction linking back to this PR. |
Contributor
@patak-dev Sorry, I'll open a PR to fix it~ |
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Co-authored-by: liyan1 <[email protected]> Co-authored-by: sapphi-red <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I use
vite-plugin-mkcert, this issue occurs，this change will have an expression different from the previous version.Here, the host is configured as
dev.aaaa.com. In previous versions, startingvitewould automatically openhttps://dev.aaaa.com:5137/.In the new version, it will open
https://localhost:5173/.To maintain consistency with the previous version, need to modify
server.openinvite.conf.mtstohttps://dev.aaaa.com:5173/.Can it be opened using the domain name of
serve.hostinstead ofhttps://localhost:5173/?Related: #19317 (comment)
It seems to be the first domain automatically opened.
vite/packages/vite/src/node/server/index.ts
Lines 661 to 662 in 051370a