fix(ssr): combine empty source mappings#19226
Merged
patak-dev merged 1 commit intovitejs:mainfrom Jan 23, 2025
Merged
Conversation
patak-dev
approved these changes
Jan 20, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
6 tasks
blake-newman
added a commit
to blake-newman/vitest
that referenced
this pull request
Jun 2, 2025
vitejs/vite#19226 introduced a change where by empty source mappings are not combined. As such when vitest has an internal error caused such as using jsdom feature that is not implemented which logs an error it tries to map the source map when the mapping is empty which results in an error such as: ``` Cannot read properties of undefined (reading 'map') ❯ VirtualConsole.<anonymous> node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/virtual-console.js:29:53 ❯ module.exports node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:12:26 ❯ HTMLAudioElementImpl.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/nodes/HTMLMediaElement-impl.js:112:5 ❯ HTMLAudioElement.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/generated/HTMLMediaElement.js:109:34 ``` When the error originates from a file without source mapping such as `x.vue` it errors instead of logging original error.
blake-newman
added a commit
to blake-newman/vitest
that referenced
this pull request
Jun 2, 2025
vitejs/vite#19226 introduced a change where by empty source mappings are not combined. As such when vitest has an internal error caused such as using jsdom feature that is not implemented which logs an error it tries to map the source map when the mapping is empty which results in an error such as: ``` Cannot read properties of undefined (reading 'map') ❯ VirtualConsole.<anonymous> node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/virtual-console.js:29:53 ❯ module.exports node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:12:26 ❯ HTMLAudioElementImpl.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/nodes/HTMLMediaElement-impl.js:112:5 ❯ HTMLAudioElement.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/generated/HTMLMediaElement.js:109:34 ``` When the error originates from a file without source mapping such as `x.vue` it errors instead of logging original error.
blake-newman
added a commit
to blake-newman/vitest
that referenced
this pull request
Jun 2, 2025
vitejs/vite#19226 introduced a change where by empty source mappings are not combined. As such when vitest has an internal error caused such as using jsdom feature that is not implemented which logs an error it tries to map the source map when the mapping is empty which results in an error such as: ``` Cannot read properties of undefined (reading 'map') ❯ VirtualConsole.<anonymous> node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/virtual-console.js:29:53 ❯ module.exports node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:12:26 ❯ HTMLAudioElementImpl.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/nodes/HTMLMediaElement-impl.js:112:5 ❯ HTMLAudioElement.load node_modules/.pnpm/[email protected]/node_modules/jsdom/lib/jsdom/living/generated/HTMLMediaElement.js:109:34 ``` When the error originates from a file without source mapping such as `x.vue` it errors instead of logging original error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
devfor large files, i.e Astro 5's data layer #19218Current SSR transform skips collapsing
map: { mappings: '' }and uses magic-string generated map as is. However this is incorrect since empty mappings should get collapsed to empty mappings. Additionally, magic-string source map generation is unnecessary, so it can be skipped in this case.This change fixes a perf hit when plugin returns a large code from
loadortransformwith explicit empty mapppingmap: { mappings: '' }as par rollup convention https://rollupjs.org/plugin-development/#source-code-transformations.