fix(resolve): support resolving TS files by JS extension specifiers in JS files#18889
Merged
patak-dev merged 2 commits intovitejs:mainfrom Jan 23, 2025
Conversation
sapphi-red
added
the
p3-minor-bug
patak-dev
previously approved these changes
Dec 5, 2024
bluwy
previously approved these changes
Dec 6, 2024
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Nice! Thanks for researching that. This makes the implementation a lot simpler.
hi-ogawa
approved these changes
Dec 6, 2024
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Thanks! There were people asking on Vitest too vitest-dev/vitest#5999
Member
Author
|
/ecosystem-ci run |
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
6 tasks
|
📝 Ran ecosystem CI on
✅ analogjs, astro, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, storybook, sveltekit, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress |
patak-dev
approved these changes
Jan 23, 2025
sapphi-red
deleted the
fix/support-resolving-ts-files-with-js-extensions
branch
Closed
6 tasks
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Apr 23, 2025
<!-- Thank you for contributing! --> ### Description Ported changes from the following PRs: - vitejs/vite#18889 - vitejs/vite#19300 - vitejs/vite#18584, vitejs/vite#19312 and some minor changes. With this PR and #4270, the tests in Vite repo should now pass with native resolve plugin. <!-- Please insert your description here and provide especially info about the "what" this PR is solving --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Apr 23, 2025
<!-- Thank you for contributing! --> ### Description Ported changes from the following PRs: - vitejs/vite#18889 - vitejs/vite#19300 - vitejs/vite#18584, vitejs/vite#19312 and some minor changes. With this PR and #4270, the tests in Vite repo should now pass with native resolve plugin. <!-- Please insert your description here and provide especially info about the "what" this PR is solving --> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the past meeting, we decided to support
.js->.tsresolving in JS files based onmoduleResolution. We thought that TS requiresmoduleResolutionto be set toNode16or above at that time.But it seems TypeScript allows importing TS files by JS extension specifiers regardless of
moduleResolution.https://stackblitz.com/edit/vitejs-vite-hvbhlg?file=tsconfig.json,sub1.ts,sub2.mts,main1.js&terminal=build
Surprisingly, this behavior seems to be there since TS 2.0 🫨(microsoft/TypeScript#8895, found the link in esbuild repo).
This PR allows the
.js->.tsresolving in JS files regardless ofmoduleResolution.fixes #8993
refs #5510