feat!: make import.meta.hot.send async#18750
Closed
sapphi-red wants to merge 2 commits intovitejs:mainfrom
Closed
Conversation
sapphi-red
added
p3-minor-bug
Member
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress |
Member
Author
|
closing as #18753 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error that happened inside
sendmethod ofModuleRunnerTransportwas not able to handle.This PR fixes that by
awaiting on thesendmethod. This requires theimport.meta.hot.sendto be alsoawaited (thus a breaking change). Thisawaitwas not required in Vite 5 because we only used WS and WS's send is sync. In #18362, I made the ModuleRunnerTransport to allow asyncsendjust because I thought there may be a place that require async and didn't find any breaking change by doing so.Alternative way to solve this is #18751.