Repository navigation
Conversation
hybrist
force-pushed
the
jk-import-meta-debug
branch
2 times, most recently
from
October 21, 2024 18:21
ca2800c to
8232f70
Compare
Adds an alternative to `process.env.NODE_ENV`-based guards. It's a simple boolean and doesn't require the use of node-specific APIs in non-node code.
hybrist
force-pushed
the
jk-import-meta-debug
branch
from
October 21, 2024 19:06
8232f70 to
4148214
Compare
sapphi-red
added
the
p2-to-be-discussed
Member
|
https://github.com/jkrems/md/blob/main/import-meta-debug.md#package-exports-development The downside of using I think this needs some kind of standard otherwise the whole benefit will disappear, but the discussion about that seems to be happening on the webpack PR. (This is just my take. I'll try to talk about this in the next team meeting.) |
Member
|
Closing this PR as it seems Webpack isn't interested in this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an alternative to
process.env.NODE_ENV-based guards. It's a simple boolean and doesn't require the use of node-specific APIs in non-node code.See: https://github.com/jkrems/md/blob/main/import-meta-debug.md
Or just skip ahead to the section that defines this new property: https://github.com/jkrems/md/blob/main/import-meta-debug.md#importmetaDEBUG.
The goal is to have this property reliably available across tools. PRs across bundlers:
I wouldn't be surprised if there's some bikeshedding on the name (
.DEBUGvs.DEVvs.developmentvs ..?). So it's likely a good idea to hold off on landing it in any of the tools before there's a broader consensus on the name. The API itself seems simple enough that I'm not expecting a lot of churn.